feat(Reactions): Support super reactions #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has someone tested this? I can't reliably test this myself |
bsian03
requested changes
Jan 21, 2024
This PR is still a draft cuz Discord haven't updated their docs yet to match all of the props I've used here. Probably best to test it when both of those PRs are merged just in case they change anything else 👍🏻 |
|
I personally don't think it's worth waiting until Discord confirms docs. Also we previously had stuff which was undocumented (can't remember which ones exactly), and if there are any changes, we can just update accordingly |
bsian03
reviewed
Feb 4, 2024
|
I'll take a further look at this once I get my PR done |
bsian03
requested changes
Jun 6, 2024
bsian03
requested changes
Jun 9, 2024
bsian03
reviewed
Jul 8, 2024
bsian03
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super Reactions!
Adds support for super reactions! Pretty sure Discord is still in the process of adding some of it from the docs, so some of the properties Ive used are from open PRs on the Discord API repo
Also adds support for specifying a reaction type when using
Message#getReaction()and allgetMessageReaction()functionsChanges/Additions
burst_colors,count_details&me_burstadded toMessage#reactionsreaction objectsmessageReactionAdd&messageReactionRemoveevents send additionalburst(boolean) parameter to bound functiontypeoption added to thegetReaction()function within Message, as well as thegetMessageReaction()function within Client, DMChannel & GuildTextableChannel,Testing:
MESSAGE_REACTION_ADD & MESSAGE_REACTION_REMOVE rawWS screenshots
Message Reaction Add (Normal Emoji)
Message Reaction Remove (Normal Emoji)
Message Reaction Add (Burst Emoji)
Message Reaction Remove (Burst Emoji)
Note:
burst_colorsis never sent with MESSAGE_REACTION_REMOVE, even when it's a burst reaction, so I'll leave that property out completely rather than just sending an empty array to the event.Message object with burst reaction
This screenshot shows a message with 1 normal reaction, and 1 burst reaction. I'll add more screenshots here when I've finished the todo list and can continue testing 👍🏻